Fix build GHA #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstello
approved these changes
May 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refines the GitHub Actions workflow to support both push and pull request builds, updates pnpm setup, and tightens deployment settings.
- Added
pull_requesttrigger and manual dispatch - Bumped
pnpm/action-setupto v4 and simplified install/build steps - Configured artifact retention and conditional deploy only on
main
| run: | | ||
| cd docs | ||
| pnpm install | ||
| run: pnpm install |
There was a problem hiding this comment.
The pnpm install step now runs in the repository root instead of the docs directory. To restore the previous behavior, either add working-directory: docs under this step or reintroduce cd docs before the install command.
Suggested change
| run: pnpm install | |
| run: pnpm install | |
| working-directory: docs |
| run: | | ||
| cd docs | ||
| pnpm run build | ||
| run: pnpm run build |
There was a problem hiding this comment.
The pnpm run build step also runs in the root instead of docs. Use working-directory: docs here or add cd docs to ensure the build runs in the correct folder.
Suggested change
| run: pnpm run build | |
| run: pnpm run build | |
| working-directory: docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.